chore(tests): Enable testing on node.js v18.x on GitHub CI #6619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Proposed Changes
Enable testing on node.js v18.x now that:
jsdom
has been updated from v15 to v20 by chore(deps): bump jsdom from 15.2.1 to 20.0.2 #6591, andwebdriverio
has been updated from v7 to v8 by chore(deps): bump webdriverio from 7.26.0 to 8.0.5 #6686puppeteer
dependency to v14Behaviour Before Change
The
build.yml
workflow (main tests) was run on node.js v14 and v16 but not yet v18, due to incompatibility between node.js v18 andjsdom
v15 andpuppeteer
v13.Behaviour After Change
The
build.yml
workflow is run on node.js v14, v16 and v18.Reason for Changes
Make sure tests pass on current LTS version of node.js.
Test Coverage
Improved.