Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Enable testing on node.js v18.x on GitHub CI #6619

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

cpcallen
Copy link
Contributor

@cpcallen cpcallen commented Nov 14, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Proposed Changes

Enable testing on node.js v18.x now that:

Behaviour Before Change

The build.yml workflow (main tests) was run on node.js v14 and v16 but not yet v18, due to incompatibility between node.js v18 and jsdom v15 and puppeteer v13.

Behaviour After Change

The build.yml workflow is run on node.js v14, v16 and v18.

Reason for Changes

Make sure tests pass on current LTS version of node.js.

Test Coverage

Improved.

@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Nov 14, 2022
@cpcallen cpcallen force-pushed the test-node-18 branch 5 times, most recently from c5f4689 to a74b934 Compare November 16, 2022 11:45
The calls to `npm run test:prepare` in `tests/scripts/setup_*_env.sh`
should have been removed along with that npm script in PR google#4906.
@cpcallen cpcallen marked this pull request as ready for review January 5, 2023 12:02
@cpcallen cpcallen requested a review from a team as a code owner January 5, 2023 12:02
@cpcallen cpcallen requested a review from gonfunko January 5, 2023 12:02
@github-actions github-actions bot added PR: chore General chores (dependencies, typos, etc) and removed PR: chore General chores (dependencies, typos, etc) labels Jan 5, 2023
@cpcallen
Copy link
Contributor Author

cpcallen commented Jan 5, 2023

I'm beginning to think that node.js v18 is just cursed. Why is it failing now?

@cpcallen
Copy link
Contributor Author

cpcallen commented Jan 9, 2023

Seems build failure was transient. I'm a bit concerned that this might reoccur (and possibly more often on v18 than on v14 or v16), but I'm going to go ahead and merge this PR for now; we can always roll back if tests are so flakey on v18 that it starts to cause inconvenience—and in the meantime, better that we at least try to test on that version.

@cpcallen cpcallen merged commit f1e5f22 into google:develop Jan 9, 2023
@cpcallen cpcallen deleted the test-node-18 branch January 9, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests PR: chore General chores (dependencies, typos, etc)
Projects
None yet
2 participants