fix: Fix downloading screenshots on the playground. #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Mar 24, 2022
tests/playgrounds/screenshot.js
Outdated
| @@ -95,7 +95,7 @@ function workspaceToSvg_(workspace, callback, customCss) { | |||
| * Download a screenshot of the blocks on a Blockly workspace. | |||
| * @param {!Blockly.WorkspaceSvg} workspace The Blockly workspace. | |||
| */ | |||
| Blockly.downloadScreenshot = function(workspace) { | |||
| const downloadScreenshot = function(workspace) { | |||
There was a problem hiding this comment.
Could you please add an eslint-ignore statement to silence this warning?
There was a problem hiding this comment.
Just converted it to a function declaration.
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#6023
Proposed Changes
This PR fixes the Download Screenshot command in the workspace contextual menu in the playgrounds.
Behavior Before Change
The contextual menu item had no visible effect and logged an error to the console.
Behavior After Change
A screenshot of the workspace is downloaded.