Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyouts do not recalculate delete area #4912

Closed
BeksOmega opened this issue Jun 14, 2021 · 1 comment
Closed

Flyouts do not recalculate delete area #4912

BeksOmega opened this issue Jun 14, 2021 · 1 comment
Assignees
Labels
component: toolbox/flyout issue: bug Describes why the code or behaviour is wrong

Comments

@BeksOmega
Copy link
Collaborator

Describe the bug

If you have a simple toolbox (ie just a flyout) you can modify the blocks within the flyout before dragging them out. When you modify the blocks, this can cause the size of the flyout to change. However, the delete area is still the old size.

To Reproduce

Steps to reproduce the behavior:

  1. Go to the advanced playground and open the simple toolbox.
  2. Drag any block out of the flyout.
  3. Go down to the last block in the flyout and change the dropdown from "letter #" to "letter # from end" to make the flyout wider.
  4. Drag the block you created back over the flyout, and observe how the delete area is still the old size.

Note: if you switch steps 2 and 3, it doesn't reproduce. No clue what's up with that.

Expected behavior

The delete area should update based on the size of the flyout.

Screenshots

delete-area-old

@BeksOmega BeksOmega added issue: triage Issues awaiting triage by a Blockly team member issue: bug Describes why the code or behaviour is wrong labels Jun 14, 2021
@alschmiedt alschmiedt added component: toolbox/flyout and removed issue: triage Issues awaiting triage by a Blockly team member labels Jun 15, 2021
@alschmiedt alschmiedt added this to the 2021_q2_release milestone Jun 15, 2021
@moniika
Copy link
Contributor

moniika commented Jun 16, 2021

Drag target areas are re-calculated when WorkspaceSvg.prototype.recordDragTargets is called.
In this case, we would need to trigger re-calculating the drag targets when the flyout resizes with a call to recordDragTargets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: toolbox/flyout issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

4 participants