-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow changes in ad group count and order (to support pause-roll ads). #5482
Comments
As you already pointed out, there are two possible paths this can be implemented: as an AdsMediaSource or by manipulating a ConcatenatingMediaSource. AdsMediaSource Implementation: Write your own AdsLoader which published an
So if you can specifiy the number of total ad breaks in advance and then move them around (without chaning their order) this would potentially work from 2.10. onwards. ConcatenatingMediaSource Implementation: Wrap all content pieces in |
Enhancement added for the feature of changing the number (and order) of ad breaks in |
I don't think this is already tracked, so let's use this issue. Thanks! |
@tonihei I would like to try concatenating source approach with custom Timebar.
Can I simply remove current content piece and then immediately add content source clipped to pause time, pause-roll ad source, and next content source clipped to start from pause time? Will it help to get around #3163 without wating for 2.10? |
Unfortunately, that won't work because the id of the currently played content will change and the player would assume the current content isn't there anymore. It will probably transition to the ENDED state in such a case. |
Thanks, for clarifying. Will wait for 2.10 version then. |
@tonihei as 2.11.4 has been released by now I was wondering if this is likely to be implemented in the near future. Alternatively I'd be fine with a ConcatenatingMediaSource wrapping several ClippingMediaSources but I assume it is still not possible to adjust the duration of a ClippingMediaSource while it is playing (#3163). Another option I was considering is to jump to the next child source when an ad break is coming, is there a way to do this? And will the next source always be pre-buffered or will buffering start only just before reaching the next playlist item? If this were possible I'd have a messed up timeline but I would rather implement my own mapping than having to change media sources for the transitions every time and thus causing a lot of buffering. |
This enhancement is unfortunately not on our agenda for now. The idea with jumping to the next source sounds like a good idea, but again depends on an unimplemented feature. #3327 is tracking the pre-buffering of the next item (before the currently playing one is finished buffering). This is an often requested feature and the one most likely to be implemented next (of these 3 features). Sorry I can't be more helpful, but there doesn't seem to be an option to seamlessly support dynamic ad insertion for now. |
I wonder if there is a way of creating some custom media source with pause-roll support (pause-roll is an ad that is started when user resumes video from pause)?
AdsMediaSource does not support it and also is not accurate with delivering player states (#5209)
It seems that dynamic ConcatenatingMediaSource (combined from ClippingMediaSources with content and ad sources) might do the trick, but I'm not sure if there is a way to make player show the whole timebar for content instead of just timebar for current media source - is there a way?
Currently for post-roll I just save content position and load ad media and then reload content media back. But I would like to have that logic wrapped into custom media source to make my player code simpler.
The text was updated successfully, but these errors were encountered: