Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Athens server docker image for armv6 #1227

Closed
atomi opened this issue May 16, 2019 · 11 comments
Closed

Publish Athens server docker image for armv6 #1227

atomi opened this issue May 16, 2019 · 11 comments
Labels
proposal A proposal for discussion and possibly a vote question Further information is requested

Comments

@atomi
Copy link

atomi commented May 16, 2019

Since Athens is using Drone which also offers a plugin to publish manifest files can multi arches be supported?

http://plugins.drone.io/drone-plugins/drone-manifest/

I was able to build 955929d just fine on a Raspberry Pi 3 with only a tiny change in the Dockerfile

diff --git a/cmd/proxy/Dockerfile b/cmd/proxy/Dockerfile
index fe2a691..88506ad 100644
--- a/cmd/proxy/Dockerfile
+++ b/cmd/proxy/Dockerfile
@@ -14,7 +14,7 @@ RUN DATE="$(date -u +%Y-%m-%d-%H:%M:%S-%Z)" && GO111MODULE=on CGO_ENABLED=0 go b
 
 # Add tini, see https://github.com/gomods/athens/issues/1155 for details.
 ENV TINI_VERSION v0.18.0
-ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-static /tini
+ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-static-armhf /tini
 RUN chmod +x /tini
 
 FROM alpine

Edit: Obviously this is not critical but it would be a nice to have for further updates. Thanks.

@atomi
Copy link
Author

atomi commented May 16, 2019

So for what it's worth, I've been playing around with Athens on the Pi and it does indeed work but it is pretty slow.

So I'm not sure there will be many takers. 🤔

@Kunde21
Copy link
Contributor

Kunde21 commented May 17, 2019

Is there a reason the Dockerfile doesn't use the alpine tini package directly?

@atomi
Copy link
Author

atomi commented May 17, 2019

Is there a reason the Dockerfile doesn't use the alpine tini package directly?

I wasn't aware tini was available in alpine but probably not.
It looks like it's the same version available as well.

@marpio marpio added proposal A proposal for discussion and possibly a vote question Further information is requested labels May 31, 2019
@marpio
Copy link
Member

marpio commented May 31, 2019

I think it's interesting b/c it would potentially enable Athens to run on AWS EC2 A1 or Scaleway ARM servers https://www.scaleway.com/en/arm-instances/

@Kunde21
Copy link
Contributor

Kunde21 commented Jun 1, 2019

I've built athens on arm, arm64, and amd64 with a multiarch manifest here: hub.docker.com/r/kunde21/athens-arm

I'll be testing on my local hardware (rpi3 and odroid XU4), but it would be good to get others to test, too. Main focus for testing is performance on different hardware, so we can give some general recommendations when it's released on the official gomods dockerhub.

@atomi
Copy link
Author

atomi commented Jun 1, 2019

By the way, according to the tini README an init is included in docker now by passing --init so I'm not sure tini is even necessary anymore.

Edit: So since docker doesn't make --init default it's probably a good bet to keep it as is. Sorry for the noise.

@marpio
Copy link
Member

marpio commented Jun 1, 2019

@atomi no problem!
The reason we have it is #1155

@atomi
Copy link
Author

atomi commented Jun 1, 2019

@marpio Thank you!

@arschles
Copy link
Member

@atomi @marpio @Kunde21 since we closed #1155 and we stick with running Athens under tini in our images, do you think we can close this?

@atomi
Copy link
Author

atomi commented Oct 16, 2019

Apologies. Yes!

@atomi atomi closed this as completed Oct 16, 2019
@arschles
Copy link
Member

No apologies necessary @atomi. Thanks for responding 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for discussion and possibly a vote question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants