diff --git a/go.mod b/go.mod index 9ca55fe9ec45..627650c09d6f 100644 --- a/go.mod +++ b/go.mod @@ -59,7 +59,7 @@ require ( github.com/julz/importas v0.1.0 github.com/karamaru-alpha/copyloopvar v1.0.9 github.com/kisielk/errcheck v1.7.0 - github.com/kkHAIKE/contextcheck v1.1.4 + github.com/kkHAIKE/contextcheck v1.1.5 github.com/kulti/thelper v0.6.3 github.com/kunwardeep/paralleltest v1.0.10 github.com/kyoh86/exportloopref v0.1.11 diff --git a/go.sum b/go.sum index dcbd659b4269..89b17bcb6832 100644 --- a/go.sum +++ b/go.sum @@ -319,8 +319,8 @@ github.com/karamaru-alpha/copyloopvar v1.0.9/go.mod h1:u7CIfztblY0jZLOQZgH3oYsJz github.com/kisielk/errcheck v1.7.0 h1:+SbscKmWJ5mOK/bO1zS60F5I9WwZDWOfRsC4RwfwRV0= github.com/kisielk/errcheck v1.7.0/go.mod h1:1kLL+jV4e+CFfueBmI1dSK2ADDyQnlrnrY/FqKluHJQ= github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck= -github.com/kkHAIKE/contextcheck v1.1.4 h1:B6zAaLhOEEcjvUgIYEqystmnFk1Oemn8bvJhbt0GMb8= -github.com/kkHAIKE/contextcheck v1.1.4/go.mod h1:1+i/gWqokIa+dm31mqGLZhZJ7Uh44DJGZVmr6QRBNJg= +github.com/kkHAIKE/contextcheck v1.1.5 h1:CdnJh63tcDe53vG+RebdpdXJTc9atMgGqdx8LXxiilg= +github.com/kkHAIKE/contextcheck v1.1.5/go.mod h1:O930cpht4xb1YQpK+1+AgoM3mFsvxr7uyFptcnWTYUA= github.com/klauspost/compress v1.13.4/go.mod h1:8dP1Hq4DHOhN9w426knH3Rhby4rFm6D8eO+e+Dq5Gzg= github.com/klauspost/compress v1.13.5/go.mod h1:/3/Vjq9QcHkK5uEr5lBEmyoZ1iFhe47etQ6QUkpK6sk= github.com/konsorten/go-windows-terminal-sequences v1.0.1/go.mod h1:T0+1ngSBFLxvqU3pZ+m/2kptfBszLMUkC4ZK/EgS/cQ= diff --git a/pkg/result/processors/invalid_issue.go b/pkg/result/processors/invalid_issue.go index a8cfef892087..3bb0eb639072 100644 --- a/pkg/result/processors/invalid_issue.go +++ b/pkg/result/processors/invalid_issue.go @@ -33,10 +33,7 @@ func (p InvalidIssue) shouldPassIssue(issue *result.Issue) (bool, error) { } if issue.FilePath() == "" { - // contextcheck has a known bug https://github.com/kkHAIKE/contextcheck/issues/21 - if issue.FromLinter != "contextcheck" { - p.log.Warnf("no file path for the issue: probably a bug inside the linter %q: %#v", issue.FromLinter, issue) - } + p.log.Warnf("no file path for the issue: probably a bug inside the linter %q: %#v", issue.FromLinter, issue) return false, nil } @@ -47,6 +44,7 @@ func (p InvalidIssue) shouldPassIssue(issue *result.Issue) (bool, error) { if !isGoFile(issue.FilePath()) { p.log.Infof("issue related to file %s is skipped", issue.FilePath()) + return false, nil }