gopls: crashes in analysis with missing stacktrace

[findleyr]

A recent change to gopls introduced a log.Fatal in the analysis driver when encountering an 'impossible state' (golang/go#60963). We've since discovered and fixed one such impossible state (golang/go#60952), but there may be others.

We believe this is the cause of the numerous blank crash reports in this issue tracker.

We're going to cut a new gopls release today containing a fix for the known failure mode, and downgrading this call to log.Fatal. Pinning this issue for visibility in the meantime. Sorry for the breakage.

If you encounter such a crash, we would greatly apprecate it if you could look in the gopls output panel and capture the fatal log message. This would help us determine if we have indeed fixed the root cause.
<!--

CC @hyangah @adonovan

[findleyr]

We believe these crashes have been fixed by gopls@v0.12.4.

go install golang.org/x/tools/gopls@latest

However, I'll leave this issue open until we have confidence that the crash reports have resolved.

[sreerajsmenon01]

Crash_Gopls.txt
Please find the attachment

[findleyr]

Thanks @sreerajsmenon01. That looks like an OOM:

runtime: out of memory: cannot allocate 4194304-byte block (1551564800 in use)
fatal error: out of memory

Notably the runtime is reporting 1.5G in-use. While that is high, it is not entirely unreasonable during an analysis pass. Are you working in a significantly memory-constrained environment?

[findleyr]

Ok, closing this issue as we had no further crashes over the weekend.