-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: mod tidy replaces non-semver strings non-friendly ones #32883
Comments
Have you tried this with the 1.13 beta? Can you share a way to reproduce this issue, or at least show the before and after of |
Before:
After:
See the k8s.io/api line. |
I assume this is because it's not following the |
Yes, that's exactly why. My point is that the replacement is unfriendly. |
Also yes, go1.13 behaves the same way as expected. |
Some related discussion in #25898. |
Also, a little more context on the current behavior is in https://golang.org/cmd/go/#hdr-Module_queries :
... where the last sentence in that quote is what’s happening in your example I think. (Pseudo-versions are an important part of the system. They include a timestamp and a commit hash, and they allow a total ordering across versions recorded in go.mod and make it easier to reason about which recorded versions are considered "later" than another recorded version). |
Yes, I'm posting this issue because this is a poor user experience. |
Duplicate of #25898 |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Run
go mod tidy
with custom/non-semver tagsWhat did you expect to see?
Still be able to tell what tag was put there
What did you see instead?
It replaces it with semi-gibberish.
Would be nice if it at least put the tag string in a comment.
The text was updated successfully, but these errors were encountered: