Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor complete set of migrate drivers #16420

Closed
nyarly opened this issue Feb 25, 2022 · 4 comments
Closed

Vendor complete set of migrate drivers #16420

nyarly opened this issue Feb 25, 2022 · 4 comments
Labels
area/database help wanted The issues that is valid but needs help from community kind/requirement New feature or idea on top of harbor Stale

Comments

@nyarly
Copy link

nyarly commented Feb 25, 2022

I'm trying to address #8649 and finding that, while I can reproduce the pg_advisory_lock issue in tests, when I try to switch the migrator to use cockroachdb I run into trouble. It seem that the database directory in golang-migrate/migrate has been stripped back to just postgresql.

Would you please restore the database directory of that package? Or at least database/cockroachdb?

Thanks very much.

@wy65701436 wy65701436 added kind/requirement New feature or idea on top of harbor help wanted The issues that is valid but needs help from community labels Feb 28, 2022
@wy65701436 wy65701436 removed their assignment Feb 28, 2022
@nyarly
Copy link
Author

nyarly commented Mar 4, 2022

@wy65701436 @stonezdj I'm not sure I understand "help wanted" on this issue. Per CONTRIBUTING.md, core maintainers are responsible for maintaining the vendor directory, and contributors shouldn't change module dependencies.

Even so, I was experimenting with changing the module vendoring just to see if I could close the issue, and found that:

  1. I couldn't figure out how modules were being vendored in the first place. There doesn't seem to be a script or other tool for managing it,
  2. The existing go.mod doesn't seem to be legitimate; removing the vendor directory prevents the project from building
  3. Manually adding cockroach from a fresh download of the golang-migrate/migrate module isn't sufficient; there's other dependencies that brings in.

In short, what help can the community provide on this issue?

@github-actions
Copy link

github-actions bot commented May 3, 2022

This issue is being marked stale due to a period of inactivity. If this issue is still relevant, please comment or remove the stale label. Otherwise, this issue will close in 30 days.

@github-actions github-actions bot added the Stale label May 3, 2022
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This issue was closed because it has been stalled for 30 days with no activity. If this issue is still relevant, please re-open a new issue.

@github-actions github-actions bot closed this as completed Jul 5, 2022
@wwentland
Copy link

Is there a chance this could be re-opened and addressed? It would be great if:

While the second point might be less straightforward to implement, the first one should be trivial.

What would be the best way to move this forward, @wy65701436 @stonezdj ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database help wanted The issues that is valid but needs help from community kind/requirement New feature or idea on top of harbor Stale
Projects
None yet
Development

No branches or pull requests

4 participants