Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workflow event triggers (#23613) #23648

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

GiteaBot
Copy link
Contributor

Backport #23613 by @Zettat123

Follow #23037
Fix #22598 comment

Workflows with pull_request trigger event can't be triggered by pull_request_sync event. This PR adds the canGithubEventMatch function to check if a Github event can match any Gitea event. If the Github event matches a Gitea event, the related workflows should be triggered.

Follow go-gitea#23037 
Fix [go-gitea#22598
comment](go-gitea#22958 (comment))

Workflows with `pull_request` trigger event can't be triggered by
`pull_request_sync` event. This PR adds the `canGithubEventMatch`
function to check if a Github event can match any Gitea event. If the
Github event matches a Gitea event, the related workflows should be
triggered.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot added this to the 1.19.1 milestone Mar 23, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 23, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2023
@lunny lunny merged commit e7a5429 into go-gitea:release/v1.19 Mar 23, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@techknowlogick techknowlogick deleted the backport-23613-v1.19 branch September 9, 2023 05:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants