Fix offBy1 errors #17606
Merged
Fix offBy1 errors #17606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Partially resolves go-gitea#17596 - Resolve errors from go-critic `offBy1: Index() can return -1; maybe you wanted to do Index()+1`.
8 tasks
wxiaoguang
reviewed
Nov 10, 2021
GiteaBot
added
the
lgtm/need 2
added 2 commits
November 10, 2021 16:47
Codecov Report
@@ Coverage Diff @@
## main #17606 +/- ##
=======================================
Coverage ? 45.50%
=======================================
Files ? 795
Lines ? 88863
Branches ? 0
=======================================
Hits ? 40441
Misses ? 41906
Partials ? 6516
Continue to review full report at Codecov.
|
techknowlogick
approved these changes
Nov 10, 2021
GiteaBot
added
lgtm/need 1
wxiaoguang
approved these changes
Nov 10, 2021
GiteaBot
added
lgtm/done
delvh
reviewed
Nov 10, 2021
Co-authored-by: delvh <dev.lh@web.de>
lafriks
approved these changes
Nov 13, 2021
delvh
approved these changes
Nov 13, 2021
|
🚀 |
zeripath
pushed a commit
that referenced
this pull request
Nov 16, 2021
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Fix offBy1 errors - Partially resolves go-gitea#17596 - Resolve errors from go-critic `offBy1: Index() can return -1; maybe you wanted to do Index()+1`. * Match golang spec * Remove comments * Update migrations.go * Apply suggestions from code review Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
offBy1: Index() can return -1; maybe you wanted to do Index()+1.Note: for
firstHashtagIndexI haven't returned a error, as I do think it's possible that legitimate docs don't have#.But for
endColumnsIndexI have returned a error, as it do seems to be necessary.