Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move shutdownfns, terminatefns and hammerfns out of separate goroutines #15686

Closed
wants to merge 6 commits into from

Conversation

zeripath
Copy link
Contributor

Coalesce the shutdownfns etc into a list of functions that get run at shutdown
rather then have them run at goroutines blocked on selects.

This may help reduce the background select/poll load in certain
configurations.

Signed-off-by: Andrew Thornton art27@cantab.net

Coalesce the shutdownfns etc into a list of functions that get run at shutdown
rather then have them run at goroutines blocked on selects.

This may help reduce the background select/poll load in certain
configurations.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.0 milestone Apr 30, 2021
@zeripath
Copy link
Contributor Author

Ref #15048
Ref #15542

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the performance/speed performance issues with slow downs label May 1, 2021
@zeripath zeripath changed the title move shutdownfns, terminatefns and hammerfns out of separate goroutines Move shutdownfns, terminatefns and hammerfns out of separate goroutines May 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15686 (8d3464a) into master (8c8471e) will decrease coverage by 0.02%.
The diff coverage is 22.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15686      +/-   ##
==========================================
- Coverage   43.90%   43.88%   -0.03%     
==========================================
  Files         678      678              
  Lines       81868    81883      +15     
==========================================
- Hits        35946    35934      -12     
- Misses      40075    40096      +21     
- Partials     5847     5853       +6     
Impacted Files Coverage Δ
modules/graceful/manager.go 25.56% <15.94%> (-3.47%) ⬇️
modules/graceful/context.go 18.18% <66.66%> (-46.11%) ⬇️
modules/graceful/manager_unix.go 36.63% <100.00%> (ø)
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/notification/mail/mail.go 41.83% <0.00%> (+3.06%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8471e...8d3464a. Read the comment docs.

@zeripath
Copy link
Contributor Author

zeripath commented May 3, 2021

I'm gonna close this to move its changes in to #15693

@zeripath zeripath closed this May 3, 2021
@zeripath zeripath deleted the graceful-context branch May 3, 2021 20:37
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. performance/speed performance issues with slow downs type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants