Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] global explore show repos of hidden org #9555

Closed
6543 opened this issue Dec 30, 2019 · 2 comments · Fixed by #9609
Closed

[bug] global explore show repos of hidden org #9555

6543 opened this issue Dec 30, 2019 · 2 comments · Fixed by #9609
Labels
Milestone

Comments

@6543
Copy link
Member

6543 commented Dec 30, 2019

Bildschirmfoto zu 2019-12-31 00-39-16

if you like to look at it - you get a 404 wich shows that the repo view handle rights in a correct way

@lunny lunny added the type/bug label Dec 31, 2019
@lunny lunny added this to the 1.11.0 milestone Jan 5, 2020
@jolheiser
Copy link
Member

To aid anyone looking into this, the problem comes from

gitea/models/repo_list.go

Lines 230 to 232 in 0842464

if opts.AllPublic {
accessCond = accessCond.Or(builder.Eq{"is_private": false})
}

Because even though the repo is public, this condition doesn't take private orgs into account.
I have been mulling it over off and on, but truth be told that function is a tricky mess that needs refactoring imo
I'll keep thinking on it, but in the meantime someone else is more than welcome to swoop in and take it. 😅

@6543
Copy link
Member Author

6543 commented Jan 5, 2020

@jolheiser how do you create this code views in markdown?

@lafriks lafriks modified the milestones: 1.11.0, 1.10.3 Jan 6, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants