Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons in file comment don't display properly #8136

Closed
2 of 7 tasks
StephenKingJJY opened this issue Sep 10, 2019 · 3 comments · Fixed by #8614
Closed
2 of 7 tasks

icons in file comment don't display properly #8136

StephenKingJJY opened this issue Sep 10, 2019 · 3 comments · Fixed by #8614
Labels
Milestone

Comments

@StephenKingJJY
Copy link

Description

...
There is maybe a css error. Icons represented for editing and deleting could not show properly in file page .

Screenshots

image

@guillep2k
Copy link
Member

Strange... this is what I see (as I expect):

image

Things that come to my mind:

  • Perhaps you page rendered in a character encoding different from UTF-8?
  • Perhaps your browser was unable to load some resources? Can you open the developer tools on your browser and check in the network tab if any requests ar failing?

@StephenKingJJY
Copy link
Author

image
You can leave your own comment and find that.

@guillep2k
Copy link
Member

Oh, now I see it! It's a template problem indeed. .code-view is overriding octicons font settings when the comment is inside a code review; perhaps only code should be wrapped in .code-view, while headers and such should be out of it.
templates/repo/issue/view_content/comments.tmpl wraps with view-code
templates/repo/diff/section_unified.tmpl uses octicons, but font gets overriden.
I'll leave that info here in case someone wants to pick up the issue.

@lunny lunny added the type/bug label Oct 21, 2019
@lunny lunny added this to the 1.10.0 milestone Oct 21, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants