Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIN_PASSWORD_LENGTH ignored when changing the password in user settings #3036

Closed
2 of 7 tasks
jhasse opened this issue Nov 30, 2017 · 1 comment · Fixed by #3039
Closed
2 of 7 tasks

MIN_PASSWORD_LENGTH ignored when changing the password in user settings #3036

jhasse opened this issue Nov 30, 2017 · 1 comment · Fixed by #3039
Labels
type/bug
Milestone
1.4.0

Comments

@jhasse
Copy link

jhasse commented Nov 30, 2017

  • Gitea version (or commit ref): 1.2.3
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes
    • No
    • Not relevant

Description

The MIN_PASSWORD_LENGTH configuration added in #223 is only checked when signing up or when resetting the password via email. When changing the password in the settings (e.g. https://try.gitea.io/user/settings/security) one can enter a password with any length.
@lunny lunny added the type/bug label Nov 30, 2017
@lunny lunny added this to the 1.4.0 milestone Nov 30, 2017
@lunny lunny mentioned this issue Nov 30, 2017
Merged
@jhasse
Copy link
Author

jhasse commented Dec 5, 2017

Wow that was pretty fast. Thank you very much :)

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Fix missing password length check when change password lunny/gitea
2 participants
@jhasse @lunny