Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permalink Files In PR Diff #19525

Closed
kdumontnu opened this issue Apr 27, 2022 · 1 comment · Fixed by #19534
Closed

Permalink Files In PR Diff #19525

kdumontnu opened this issue Apr 27, 2022 · 1 comment · Fixed by #19534
Assignees
@KN4CK3R
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@kdumontnu
Copy link
Contributor

Feature Description

GitHub allows users to click a file in a PR diff and copy a permalink to that file, which makes it easy to share a specific file in a PR and/or decorate a PR description.

GitHub appears to create some kind of hash for each file. For example: https://github.com/go-gitea/gitea/pull/17145/files#diff-23ceed4d2a9f0e4f08ead9fd5b74b481e40e029fd83cd0453f9c0a2edfd53577

This can be extended to adding a permalink to specific lines in the diff, but probably warrants a separate issue.

Screenshots

image
@kdumontnu kdumontnu added type/proposal The new feature has not been accepted yet but needs to be discussed first. type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Apr 27, 2022
@KN4CK3R KN4CK3R self-assigned this Apr 27, 2022
@KN4CK3R KN4CK3R mentioned this issue Apr 27, 2022
Merged
@KN4CK3R
Copy link
Member

KN4CK3R commented Apr 27, 2022

The GitHub hash is btw the sha256 of the filename.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KN4CK3R KN4CK3R

Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Permalink files In PR diff KN4CK3R/gitea
2 participants
@KN4CK3R @kdumontnu