Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web interface - spellchecker of the browser not available #18532

Closed
flobee opened this issue Feb 1, 2022 · 4 comments · Fixed by #19776
Closed

web interface - spellchecker of the browser not available #18532

flobee opened this issue Feb 1, 2022 · 4 comments · Fixed by #19776
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug

Comments

@flobee
Copy link

flobee commented Feb 1, 2022

Feature Description

The default behavior for spell checking of the browser does not work in forms. e.g when editing a README.md and want to use spell checks

Screenshots

not possible within a right mouse click

@silverwind
Copy link
Member

There is spellcheck="false" set on the underlying texarea which was probably to work around some issue. We can remove it but I'm not sure whether spell checking can even work with CodeMirror, those might require a standard <textarea>.

@flobee
Copy link
Author

flobee commented May 12, 2022

Well. Never refactor/reset standard browser functionality. Removing default user control is a completetly NOGO since ages >25Y i experience. Make all default browser standards available/possible as good you can.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented May 13, 2022

There is an option for EasyMDE/CodeMirror.

spellChecker: If set to false, disable the spell checker. Defaults to true. Optionally pass a CodeMirrorSpellChecker-compliant function.

However it was set to false in history in Gitea code. I do not think it's correct (well, maybe it was somehow correct at that moment, but there is no comment at all). The code was just Copied&Pasted from 2b10fdc4 .

A simple PR can fix this problem (maybe not simple)

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 13, 2022
@wxiaoguang wxiaoguang added type/bug topic/ui Change the appearance of the Gitea UI issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented labels May 13, 2022
@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang removed this from the 1.17.0 milestone May 24, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants