Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown code fences - mariadb language as alias to mysql #18254

Closed
hrvoj3e opened this issue Jan 12, 2022 · 6 comments
Closed

markdown code fences - mariadb language as alias to mysql #18254

hrvoj3e opened this issue Jan 12, 2022 · 6 comments
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Milestone

Comments

@hrvoj3e
Copy link

hrvoj3e commented Jan 12, 2022

Gitea Version

1.16.0

Operating System

Linux

Browser Version

Chrome 96 on Linux

Can you reproduce the bug on the Gitea demo site?

Yes

Description

SELECT z.label FROM mytable AS z WHERE id=1;
-- should highlight the same as mysql above
SELECT z.label FROM mytable AS z WHERE id=1;

Html that renders from Gitea

<pre><code class="chroma language-mariadb">
SELECT z.label FROM mytable AS z WHERE id=1;
</code></pre>

Screenshots

image

@techknowlogick techknowlogick added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Jan 12, 2022
@hrvoj3e
Copy link
Author

hrvoj3e commented Jan 16, 2022

Upstream solved this. Please pull new version for next release.

@wxiaoguang
Copy link
Contributor

We have a PR for upgrading Chroma.

Let's follow it.

@wxiaoguang wxiaoguang linked a pull request Jan 16, 2022 that will close this issue
@hrvoj3e
Copy link
Author

hrvoj3e commented Jan 19, 2022

It seems they have not included this in 0.10.0 release. Don't know why.

https://github.com/alecthomas/chroma/blob/v0.10.0/lexers/m/mysql.go

@wxiaoguang wxiaoguang removed a link to a pull request Jan 20, 2022
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jan 20, 2022
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 20, 2022

That change hasn't been released in Chroma. As discussed in #18270 , we merge 0.10.0 now, and once Chroma has a new release, we will update again then.

@lunny lunny modified the milestones: 1.17.0, 1.18.0 May 25, 2022
@lunny
Copy link
Member

lunny commented May 25, 2022

Put this to v1.18.0 but put back once Chroma released v2.0.0

@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@wxiaoguang
Copy link
Contributor

done

gitea/go.mod

Line 18 in 49a4e45

github.com/alecthomas/chroma/v2 v2.3.0

@wxiaoguang wxiaoguang modified the milestones: 1.19.0, 1.18.0 Oct 26, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Development

No branches or pull requests

4 participants