Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in Gitea 1.14 for large diffs #16130

Closed
jpraet opened this issue Jun 10, 2021 · 3 comments
Closed

Performance regression in Gitea 1.14 for large diffs #16130

jpraet opened this issue Jun 10, 2021 · 3 comments
Labels
performance/speed performance issues with slow downs

Comments

@jpraet
Copy link
Member

jpraet commented Jun 10, 2021

  • Gitea version (or commit ref): 1.14.2
  • Operating system: docker on RHEL 7.7

Due to #13949 when you want to create a PR for backporting a change to a release branch, gitea first calculates the diff against the master branch. If the branches have diverged a lot this diff can be quite large, and the processing and rendering can take a very long time. This was already quite slow on Gitea 1.13, but on Gitea 1.14 it got significantly slower.

Gitea 1.14.2:
2021/06/09 16:28:03 Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 2m15.325931649s

Same with Gitea 1.13.4:
2021-06-09 16:04:19: Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 46.343604847s

It looks like the performance has already improved again on the latest 1.15 dev version:
2021/06/10 16:00:08 Completed GET /CBSS/cics/compare/master...release/10.2 200 OK in 34.828378582s

This diff is pretty large: 375 changed files with 22643 additions and 25134 deletions.

I noticed there are other tickets about performance issues with 1.14, but they seem to be related to Windows, or to repo browsing.

@lunny lunny added the performance/speed performance issues with slow downs label Jun 10, 2021
@jpraet
Copy link
Member Author

jpraet commented Jun 10, 2021

I will try to identify the commit that improved the performance on 1.15.

@jpraet
Copy link
Member Author

jpraet commented Jun 10, 2021

It's #15667. Could it be backported to 1.14? /cc @zeripath

@wxiaoguang
Copy link
Contributor

Outdated

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance/speed performance issues with slow downs
Projects
None yet
Development

No branches or pull requests

3 participants