Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull request merged / closed webhook contains empty body #15993

Closed
jpraet opened this issue May 27, 2021 · 0 comments · Fixed by #16011
Closed

pull request merged / closed webhook contains empty body #15993

jpraet opened this issue May 27, 2021 · 0 comments · Fixed by #16011

Comments

@jpraet
Copy link
Member

jpraet commented May 27, 2021

The body is empty in the webhook payload for pull request merged / closed events.

This is causing a problem with the redmine_merge_request_links plugin: tf/redmine_merge_request_links#27

At first I thought that this behavior maybe was intentional, but looking at the code, I don't think it is:

pr.Issue.Content = ""

The pr.Issue.Content is emptied in the e-mail notification code, and as a side-effect the issue content is also empty for notifiers that are called afterwards (indexer, webhook and action).

Such unexpected manipulations of the notification input also happens here:

issue.Content = ""

comment.Content = ""

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant