-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0-rc1 tag is missing #713
Comments
This was a release candidate, not a stable release. It's likely we removed the tag for reason and not by mistake. Please refer to v4.0.0 instead. |
The problem is the version still exists on the official Go proxy so most Go users will not notice that and keep on using this version.
The only version that exists for Go is
|
yes, official go.mod support was released from /v5 /v4 was never a thing. Is there a particular reason to add v4.0.0-rc1 now..? I feel it will be mistaken for users to use /v4. I'd need to look closer at this, and unfortunately I don't have the bandwidth right now -- just checking if this is urgent and why? |
We have multiple developers running into problems caused by this missing tag and the inability to use the Go proxy. As @mx-psi mentioned:
I'd love it if our intermediate dependency didn't have that transitive dependency, but that's not in my control. I also can't |
I’m not even sure how to properly solve this? I can tag 4.0.0-rc1 but maybe I should release a 4.x.x release off the last v4 incompatible release with go.mod support for /v4. The go.mod stuff is such a mess the behaviour is difficult to predict |
Btw, for dd-trace and open-telemetry, please upgrade to chi /v5. There should be no reason a project is using /v4 or an old version, if they are, or any child dependency is using it, they should upgrade as its backwards compatible. |
Tagging
On dd-trace the usage is to provide a middleware (see https://github.com/DataDog/dd-trace-go/blob/v1/contrib/go-chi/chi.v4/chi.go ) for other users to use, so I don't think if this can be removed safely (maybe if you deprecate The OpenTelemetry Collector does not directly make use of go-chi, but it uses it indirectly because it depends on dd-trace-go. |
We're well pass this issue now. Let's close and hope everyone is on github.com/go-chi/chi/v5@latest :) |
The
v4.0.0-rc1
tag is available on thepkg.go.dev
docs domain and the official Go proxy (download here, sumdb entry here), but it looks like the tag has been removed from this repository.This breaks build for anyone that is not using the official Go proxy and is building a module that has
v4.0.0-rc1
on their dependency tree. Would it be possible for this tag to be re-added to the repository to avoid this breakage? Thanks!The text was updated successfully, but these errors were encountered: