Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim: 'Claimed!' message is displayed when a transaction fails #2082

Closed
elena-zh opened this issue Jan 11, 2022 · 4 comments · Fixed by #2355
Closed

Claim: 'Claimed!' message is displayed when a transaction fails #2082

elena-zh opened this issue Jan 11, 2022 · 4 comments · Fixed by #2355
Assignees
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

Related to #2000, #2009

  1. Connect an account with tokens available to claim in Rinkeby
  2. Connect a wallet
  3. Open Claim vCOW page
  4. Press on the 'Claim vCOW' button
  5. Specify conditions in transaction settings to get it failed (low-low gas fee, as an example)
  6. Confirm the transaction in the connected wallet

AR: User gets a message about a successful Claim, however, the transaction fails
Screenshot_1.jpg

ER: it would be nice to show the 'claiming' state until transaction is successfully executed

@elena-zh elena-zh added app:CowSwap CowSwap app Medium Severity indicator. It causes some undesirable behavior, but the system is still functional Bug Something isn't working Claim Issues related to 'Claim' feature labels Jan 11, 2022
@elena-zh
Copy link
Author

Besides, it would be nice to navigate a user to the 'vCOW claim breakdown' page after Tx fails. Currently, user stays on the 'Claimed!' page and needs to reload it in order to see claim breakdown again.

@elena-zh
Copy link
Author

Also, it would be nice to change Activity log entry to 'Claim ...vCOW' instead of 'Claimed ...vCOW', as Tx is failed, and tokens were not transferred to an account
image

@elena-zh
Copy link
Author

As reported in #2259 (comment) , the same sound is playing when a transaction is failed and is successful. So it wound is playing when a transaction is failed and is successful.

@anxolin
Copy link
Contributor

anxolin commented Jan 26, 2022

By the way, the "Calimed!" part is solved. It says now "Claim"

The part i think is more important to fix from this issue, is that if we fail we don't go to the SUCCESS page and we let the user re-attempt

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Bug Something isn't working Claim Issues related to 'Claim' feature Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants