Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of bare except clause in convert_concat #147

Open
bourcierj opened this issue Jul 1, 2022 · 0 comments
Open

Use of bare except clause in convert_concat #147

bourcierj opened this issue Jul 1, 2022 · 0 comments

Comments

@bourcierj
Copy link

bourcierj commented Jul 1, 2022

In reshape_layers.convert_concat function, there is an except clause that catches every exception (link). What is the type of exception encountered and when does this happen ? This clause should be restricted to expected types of exceptions.

Also, if an exception is raised, it falls back to using a keras Lambda layer with a custom function with tf.concat. The use of Lambda layers should be avoided. Hence the need to specify the kind of exception that can be caught in order to find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant