Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test for forwarding attributes to yielded components #892

Commits on Jan 17, 2019

  1. Configuration menu
    Copy the full SHA
    2a42ddb View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. Simplify test a bit.

    Remove wrapper div (and double splatting).
    rwjblue committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    b41b767 View commit details
    Browse the repository at this point in the history
  2. Ensure attrSplat consumes the value that was pushed.

    Prior to the changes here, for every `AttrNode` we processed we
    processed its value (handling literals, mustaches, etc). The value we
    process is then consumed by whatever operation is represented (e.g.
    `staticArg`, `dynamicArg`, `staticAttr`, `trustingAttr`, `dynamicAttr`).
    Unfortunately, when we processed the `...attributes` `AttrNode` into an
    `attrSplat` we did not also ensure to consume its value (which we don't
    really care about). The result was that we had one too many literal
    values on the `JavascriptCompiler`'s `values` array, meaning _all_ other
    operations that use a value would be getting the _prior_ operations
    value (e.g. an "off by one" issue in the values array).
    
    The fix here is to ensure that `attrSplat` consumes the value that is
    pushed to ensure things stay balanced.
    rwjblue committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    a233e05 View commit details
    Browse the repository at this point in the history