Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup fails when Cython is not available #26

Open
ink1 opened this issue Aug 4, 2019 · 2 comments
Open

setup fails when Cython is not available #26

ink1 opened this issue Aug 4, 2019 · 2 comments

Comments

@ink1
Copy link

ink1 commented Aug 4, 2019

Hi, in your setup, you are trying to handle a case when Cython is not available but it does not work so you should either put Cython as a dependency and throw an error or provide the missing file.

from Cython.Build import cythonize

If Cython is missing then

extension = 'cpp'

which leads to "fastBPE/fastBPE." + extension but there is no fastBPE/fastBPE.cpp file.

@myleott
Copy link
Contributor

myleott commented Aug 19, 2019

Ah, this file is provided in the package on pypi, but not distributed in the source on github. Can you install Cython and build that way?

@ink1
Copy link
Author

ink1 commented Aug 19, 2019

Hi, yes, that exactly what i had done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants