Skip to content

Commit

Permalink
t9813: avoid using pipes
Browse files Browse the repository at this point in the history
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.

Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Acked-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
pranitbauva1997 authored and gitster committed Jan 9, 2017
1 parent c7cf956 commit c6f44e1
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions t/t9813-git-p4-preserve-users.sh
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@ test_expect_success 'not preserving user with mixed authorship' '
make_change_by_user usernamefile3 Derek derek@example.com &&
P4EDITOR=cat P4USER=alice P4PASSWD=secret &&
export P4EDITOR P4USER P4PASSWD &&
git p4 commit |\
grep "git author derek@example.com does not match" &&
git p4 commit >actual &&
grep "git author derek@example.com does not match" actual &&
make_change_by_user usernamefile3 Charlie charlie@example.com &&
git p4 commit |\
grep "git author charlie@example.com does not match" &&
git p4 commit >actual &&
grep "git author charlie@example.com does not match" actual &&
make_change_by_user usernamefile3 alice alice@example.com &&
git p4 commit >actual &&
Expand Down

0 comments on commit c6f44e1

Please sign in to comment.