Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the current version to 1.4.0 #734

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Bump the current version to 1.4.0 #734

merged 1 commit into from
Apr 6, 2021

Conversation

tcojean
Copy link
Member

@tcojean tcojean commented Apr 6, 2021

This will be the next master release.

@tcojean
Bump the current version to 1.4.0
37e2f08 
This will be the next master release.
@tcojean tcojean self-assigned this Apr 6, 2021
@tcojean tcojean added the 1:ST:ready-for-review This PR is ready for review label Apr 6, 2021
@upsj upsj mentioned this pull request Apr 6, 2021
Merged
1 task
@ginkgo-bot ginkgo-bot added reg:build This is related to the build system. reg:example This is related to the examples. labels Apr 6, 2021
@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Apr 6, 2021
nbeams
nbeams approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@nbeams nbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

yhmtsai
yhmtsai approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you think we should also include the #731 for memory leak?

@tcojean
Copy link
Member Author

tcojean commented Apr 6, 2021

@yhmtsai This is not a proper release per se, this is only for convenience. It's fine that #731 or any other PR is merged afterwards. This is done so that we can identify the already done changes compared to 1.3.0 as part of the future 1.4.0, as well as the coming changes. I will consider actually releasing 1.4.0 when we have more DPC++ features available in develop.

thoasm
thoasm approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yhmtsai
Copy link
Member

yhmtsai commented Apr 6, 2021

@tcojean I see. Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #734 (37e2f08) into develop (b2b9bb6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #734      +/-   ##
===========================================
- Coverage    92.77%   92.76%   -0.02%     
===========================================
  Files          392      392              
  Lines        30483    30484       +1     
===========================================
- Hits         28282    28278       -4     
- Misses        2201     2206       +5
Impacted Files Coverage Δ
omp/reorder/rcm_kernels.cpp 95.06% <0.00%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8739d...37e2f08. Read the comment docs.

@tcojean tcojean merged commit 891ff67 into develop Apr 6, 2021
@tcojean tcojean deleted the bump_1.4.0 branch April 6, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbeams nbeams nbeams approved these changes

@upsj upsj upsj approved these changes

@pratikvn pratikvn pratikvn approved these changes

@thoasm thoasm thoasm approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

@Slaedr Slaedr Awaiting requested review from Slaedr

@fritzgoebel fritzgoebel Awaiting requested review from fritzgoebel

Assignees

@tcojean tcojean

Labels
1:ST:ready-to-merge This PR is ready to merge. reg:build This is related to the build system. reg:example This is related to the examples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tcojean @yhmtsai @nbeams @upsj @pratikvn @thoasm @ginkgo-bot