Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test install #721

Merged
merged 6 commits into from
Apr 11, 2021
Merged

Improve test install #721

merged 6 commits into from
Apr 11, 2021

Commits on Apr 11, 2021

  1. Fix wrong executor documentation.

    @tcojean
    tcojean committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    a115fa7 View commit details
    Browse the repository at this point in the history

  2. Make test_install be one file only.

    @tcojean
    tcojean committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    4a0698d View commit details
    Browse the repository at this point in the history

  3. Make test_install actually run some tests. 

    + Check most SpMV.
+ Check most Solvers.
    @tcojean
    tcojean committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    4bea0a2 View commit details
    Browse the repository at this point in the history

  4. Add possibility to install the smoke tests. 

    Caveat: the test installs need to be ran from the binary directory.
    @tcojean
    tcojean committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    7120267 View commit details
    Browse the repository at this point in the history

  5. Review updates. 

    + Ensure proper use of `HAS_REFERENCE`.
+ Move to `exec_ref` in all cases
+ Improve code readability and add a few documentation.
+ Improve robustness of the CMakeLists.txt.
+ Improve quality of `test_install.cpp` code.

Co-authored-by: Yuhsiang Tsai <yhmtsai@gmail.com>
Co-authored-by: Thomas Grützmacher <thomas.gruetzmacher@kit.edu>
Co-authored-by: Tobias Ribizel <ribizel@kit.edu>
    @tcojean @yhmtsai @upsj
    4 people committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    6c7d881 View commit details
    Browse the repository at this point in the history

  6. Format files 

    Co-authored-by: Terry Cojean <tcojean@users.noreply.github.com>
    @ginkgo-bot @tcojean
    ginkgo-bot and tcojean committed Apr 11, 2021
    Configuration menu
    Copy the full SHA
    dd7e36b View commit details
    Browse the repository at this point in the history