Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying Ginkgo with custom value types #73

Open
gflegar opened this issue Jun 18, 2018 · 1 comment · May be fixed by #1257
Open

Verifying Ginkgo with custom value types #73

gflegar opened this issue Jun 18, 2018 · 1 comment · May be fixed by #1257
Labels
is:enhancement An improvement of an existing feature. is:proposal Maybe we should do something this way. mod:core This is related to the core module. reg:testing This is related to testing.

Comments

@gflegar
Copy link
Member

gflegar commented Jun 18, 2018

Currently we are only compiling Ginkgo for default (float, double, std::complex<> of those) value types when checking the correctness of our implementation. (We're also testing only for double, see #32 for discussions on that).

This means that the interface that ValueType needs to have may change after a PR without anyone noticing (e.g. someone used a part of the interface of default types, which user-defined types may not have to implement).

I propose we create a dummy ValueType implementation (we would create a concept instead if TS concepts were a part of C++11), that could just be a double wrapped in a class, and have the interface that Ginkgo's ValueType has to satisfy defined. This gives us two benefits:

  • we can try to compile with this type whenever we test Ginkgo and get a compiler error whenever we inadvertently assume something new about ValueType's interface
  • users can look into this type, and see what their custom value type needs to have defined in order to work with Ginkgo
@gflegar gflegar added is:enhancement An improvement of an existing feature. is:proposal Maybe we should do something this way. reg:testing This is related to testing. labels Jun 18, 2018
@gflegar
Copy link
Member Author

gflegar commented Jun 18, 2018

Whoever is going to implement this, they might find the description in #49 useful. It give an example of compiling Ginkgo with user-defined value types (in this case FloatX).

@gflegar gflegar added the mod:core This is related to the core module. label Jun 28, 2018
@upsj upsj linked a pull request Jul 28, 2023 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement An improvement of an existing feature. is:proposal Maybe we should do something this way. mod:core This is related to the core module. reg:testing This is related to testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant