Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upper triangular solver #341

Merged
merged 8 commits into from
Sep 10, 2019
Merged

Upper triangular solver #341

merged 8 commits into from
Sep 10, 2019

Conversation

pratikvn
Copy link
Member

@pratikvn pratikvn commented Aug 31, 2019 •
edited
Loading

This PR adds a new upper triangular solver. The idea is the same as one for the lower triangular solver.

  • It also adds a random upper matrix generation.
  • A simple backward substitution algorithm for the UpperTrs solve on reference and omp.
  • Will also use the cusparse csrsmX solves for the solution on CUDA (See Cuda kernels for the upper triangular solver #342 ).

Misc:

  • Also adds some kernels tests for LowerTrs, which were forgotten.

TODO:

@pratikvn pratikvn self-assigned this Aug 31, 2019
@pratikvn pratikvn added mod:core This is related to the core module. 1:ST:do-not-merge Please do not merge PR this yet. is:new-feature A request or implementation of a feature that does not exist yet. mod:openmp This is related to the OpenMP module. 1:ST:ready-for-review This PR is ready for review mod:reference This is related to the reference module. type:solver This is related to the solvers labels Aug 31, 2019
@pratikvn pratikvn mentioned this pull request Aug 31, 2019
Merged
2 tasks
@codecov
Copy link

codecov bot commented Sep 2, 2019 •
edited
Loading

Codecov Report

Merging #341 into develop will increase coverage by 0.02%.
The diff coverage is 99.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
+ Coverage    98.23%   98.25%   +0.02%     
===========================================
  Files          238      246       +8     
  Lines        18086    18414     +328     
===========================================
+ Hits         17767    18093     +326     
- Misses         319      321       +2
Impacted Files Coverage Δ
core/test/utils/matrix_generator.hpp 100% <100%> (ø) ⬆️
reference/test/solver/upper_trs.cpp 100% <100%> (ø)
omp/test/solver/upper_trs_kernels.cpp 100% <100%> (ø)
reference/solver/upper_trs_kernels.cpp 100% <100%> (ø)
omp/solver/upper_trs_kernels.cpp 100% <100%> (ø)
reference/test/solver/upper_trs_kernels.cpp 100% <100%> (ø)
core/test/solver/upper_trs.cpp 100% <100%> (ø)
include/ginkgo/core/solver/upper_trs.hpp 100% <100%> (ø)
omp/test/solver/lower_trs_kernels.cpp 100% <100%> (ø) ⬆️
core/test/utils/matrix_generator_test.cpp 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c1edc4...4d734e3. Read the comment docs.

@thoasm thoasm mentioned this pull request Sep 3, 2019
Merged
7 tasks
@tcojean tcojean mentioned this pull request Sep 3, 2019
Merged
12 tasks
@pratikvn pratikvn force-pushed the upper-trs-solver branch 2 times, most recently from 94d29df to 7915f4c Compare September 6, 2019 22:06
@pratikvn pratikvn removed the 1:ST:do-not-merge Please do not merge PR this yet. label Sep 6, 2019
thoasm
thoasm reviewed Sep 9, 2019
View reviewed changes
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.

core/test/utils/matrix_generator.hpp Outdated Show resolved Hide resolved
core/test/utils/matrix_generator_test.cpp Outdated Show resolved Hide resolved
omp/test/solver/upper_trs_kernels.cpp Outdated Show resolved Hide resolved
omp/test/solver/upper_trs_kernels.cpp Show resolved Hide resolved
reference/test/solver/upper_trs_kernels.cpp Outdated Show resolved Hide resolved
yhmtsai
yhmtsai approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@yhmtsai yhmtsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

reference/test/solver/upper_trs_kernels.cpp Show resolved Hide resolved
thoasm
thoasm approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member

@thoasm thoasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pratikvn pratikvn merged commit 1b9b919 into develop Sep 10, 2019
@pratikvn pratikvn deleted the upper-trs-solver branch September 10, 2019 15:17
@tcojean tcojean added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Sep 10, 2019
tcojean added a commit that referenced this pull request Oct 20, 2019
@tcojean
Merge Release v1.1.0
b9bec82 
The Ginkgo team is proud to announce the new minor release of Ginkgo version
1.1.0. This release brings several performance improvements, adds Windows support, 
adds support for factorizations inside Ginkgo and a new ILU preconditioner
based on ParILU algorithm, among other things. For detailed information, check the respective issue.

Supported systems and requirements:
+ For all platforms, cmake 3.9+
+ Linux and MacOS
  + gcc: 5.3+, 6.3+, 7.3+, 8.1+
  + clang: 3.9+
  + Intel compiler: 2017+
  + Apple LLVM: 8.0+
  + CUDA module: CUDA 9.0+
+ Windows
  + MinGW and CygWin: gcc 5.3+, 6.3+, 7.3+, 8.1+
  + Microsoft Visual Studio: VS 2017 15.7+
  + CUDA module: CUDA 9.0+, Microsoft Visual Studio
  + OpenMP module: MinGW or CygWin.


The current known issues can be found in the [known issues
page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues).


Additions:
+ Upper and lower triangular solvers ([#327](#327), [#336](#336), [#341](#341), [#342](#342)) 
+ New factorization support in Ginkgo, and addition of the ParILU
  algorithm ([#305](#305), [#315](#315), [#319](#319), [#324](#324))
+ New ILU preconditioner ([#348](#348), [#353](#353))
+ Windows MinGW and Cygwin support ([#347](#347))
+ Windows Visual studio support ([#351](#351))
+ New example showing how to use ParILU as a preconditioner ([#358](#358))
+ New example on using loggers for debugging ([#360](#360))
+ Add two new 9pt and 27pt stencil examples ([#300](#300), [#306](#306))
+ Allow benchmarking CuSPARSE spmv formats through Ginkgo's benchmarks ([#303](#303))
+ New benchmark for sparse matrix format conversions ([#312](#312))
+ Add conversions between CSR and Hybrid formats ([#302](#302), [#310](#310))
+ Support for sorting rows in the CSR format by column idices ([#322](#322))
+ Addition of a CUDA COO SpMM kernel for improved performance ([#345](#345))
+ Addition of a LinOp to handle perturbations of the form (identity + scalar *
  basis * projector) ([#334](#334))
+ New sparsity matrix representation format with Reference and OpenMP
  kernels ([#349](#349), [#350](#350))

Fixes:
+ Accelerate GMRES solver for CUDA executor ([#363](#363))
+ Fix BiCGSTAB solver convergence ([#359](#359))
+ Fix CGS logging by reporting the residual for every sub iteration ([#328](#328))
+ Fix CSR,Dense->Sellp conversion's memory access violation ([#295](#295))
+ Accelerate CSR->Ell,Hybrid conversions on CUDA ([#313](#313), [#318](#318))
+ Fixed slowdown of COO SpMV on OpenMP ([#340](#340))
+ Fix gcc 6.4.0 internal compiler error ([#316](#316))
+ Fix compilation issue on Apple clang++ 10 ([#322](#322))
+ Make Ginkgo able to compile on Intel 2017 and above ([#337](#337))
+ Make the benchmarks spmv/solver use the same matrix formats ([#366](#366))
+ Fix self-written isfinite function ([#348](#348))
+ Fix Jacobi issues shown by cuda-memcheck

Tools and ecosystem:
+ Multiple improvements to the CI system and tools ([#296](#296), [#311](#311), [#365](#365))
+ Multiple improvements to the Ginkgo containers ([#328](#328), [#361](#361))
+ Add sonarqube analysis to Ginkgo ([#304](#304), [#308](#308), [#309](#309))
+ Add clang-tidy and iwyu support to Ginkgo ([#298](#298))
+ Improve Ginkgo's support of xSDK M12 policy by adding the `TPL_` arguments
  to CMake ([#300](#300))
+ Add support for the xSDK R7 policy ([#325](#325))
+ Fix examples in html documentation ([#367](#367))
tcojean added a commit that referenced this pull request Oct 21, 2019
@tcojean
Merge Release v1.1.0 for develop
20823e7 
The Ginkgo team is proud to announce the new minor release of Ginkgo version
1.1.0. This release brings several performance improvements, adds Windows support,
adds support for factorizations inside Ginkgo and a new ILU preconditioner
based on ParILU algorithm, among other things. For detailed information, check the respective issue.

Supported systems and requirements:
+ For all platforms, cmake 3.9+
+ Linux and MacOS
  + gcc: 5.3+, 6.3+, 7.3+, 8.1+
  + clang: 3.9+
  + Intel compiler: 2017+
  + Apple LLVM: 8.0+
  + CUDA module: CUDA 9.0+
+ Windows
  + MinGW and Cygwin: gcc 5.3+, 6.3+, 7.3+, 8.1+
  + Microsoft Visual Studio: VS 2017 15.7+
  + CUDA module: CUDA 9.0+, Microsoft Visual Studio
  + OpenMP module: MinGW or Cygwin.


The current known issues can be found in the [known issues
page](https://github.com/ginkgo-project/ginkgo/wiki/Known-Issues).


### Additions
+ Upper and lower triangular solvers ([#327](#327), [#336](#336), [#341](#341), [#342](#342)) 
+ New factorization support in Ginkgo, and addition of the ParILU
  algorithm ([#305](#305), [#315](#315), [#319](#319), [#324](#324))
+ New ILU preconditioner ([#348](#348), [#353](#353))
+ Windows MinGW and Cygwin support ([#347](#347))
+ Windows Visual Studio support ([#351](#351))
+ New example showing how to use ParILU as a preconditioner ([#358](#358))
+ New example on using loggers for debugging ([#360](#360))
+ Add two new 9pt and 27pt stencil examples ([#300](#300), [#306](#306))
+ Allow benchmarking CuSPARSE spmv formats through Ginkgo's benchmarks ([#303](#303))
+ New benchmark for sparse matrix format conversions ([#312](#312))
+ Add conversions between CSR and Hybrid formats ([#302](#302), [#310](#310))
+ Support for sorting rows in the CSR format by column idices ([#322](#322))
+ Addition of a CUDA COO SpMM kernel for improved performance ([#345](#345))
+ Addition of a LinOp to handle perturbations of the form (identity + scalar *
  basis * projector) ([#334](#334))
+ New sparsity matrix representation format with Reference and OpenMP
  kernels ([#349](#349), [#350](#350))

### Fixes
+ Accelerate GMRES solver for CUDA executor ([#363](#363))
+ Fix BiCGSTAB solver convergence ([#359](#359))
+ Fix CGS logging by reporting the residual for every sub iteration ([#328](#328))
+ Fix CSR,Dense->Sellp conversion's memory access violation ([#295](#295))
+ Accelerate CSR->Ell,Hybrid conversions on CUDA ([#313](#313), [#318](#318))
+ Fixed slowdown of COO SpMV on OpenMP ([#340](#340))
+ Fix gcc 6.4.0 internal compiler error ([#316](#316))
+ Fix compilation issue on Apple clang++ 10 ([#322](#322))
+ Make Ginkgo able to compile on Intel 2017 and above ([#337](#337))
+ Make the benchmarks spmv/solver use the same matrix formats ([#366](#366))
+ Fix self-written isfinite function ([#348](#348))
+ Fix Jacobi issues shown by cuda-memcheck

### Tools and ecosystem improvements
+ Multiple improvements to the CI system and tools ([#296](#296), [#311](#311), [#365](#365))
+ Multiple improvements to the Ginkgo containers ([#328](#328), [#361](#361))
+ Add sonarqube analysis to Ginkgo ([#304](#304), [#308](#308), [#309](#309))
+ Add clang-tidy and iwyu support to Ginkgo ([#298](#298))
+ Improve Ginkgo's support of xSDK M12 policy by adding the `TPL_` arguments
  to CMake ([#300](#300))
+ Add support for the xSDK R7 policy ([#325](#325))
+ Fix examples in html documentation ([#367](#367))


Related PR: #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoasm thoasm thoasm approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

@tcojean tcojean tcojean approved these changes

@hartwiganzt hartwiganzt Awaiting requested review from hartwiganzt

Assignees

@pratikvn pratikvn

Labels
1:ST:ready-to-merge This PR is ready to merge. is:new-feature A request or implementation of a feature that does not exist yet. mod:core This is related to the core module. mod:openmp This is related to the OpenMP module. mod:reference This is related to the reference module. type:solver This is related to the solvers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratikvn @thoasm @yhmtsai @tcojean