Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] infinite redirect with RedirectFixedPath #4034

Open
ALX99 opened this issue Aug 20, 2024 · 2 comments
Open

[Bug] infinite redirect with RedirectFixedPath #4034

ALX99 opened this issue Aug 20, 2024 · 2 comments

Comments

@ALX99
Copy link

ALX99 commented Aug 20, 2024

Description

Enabling RedirectFixedPath sometimes leads to infinite redirects

How to reproduce

package main

import (
	"github.com/gin-gonic/gin"
)

func main() {
	r := gin.Default()

	r.GET("/あ", func(c *gin.Context) {
		c.JSON(200, gin.H{})
	})

	r.UnescapePathValues = false
	r.UseRawPath = true
	r.RedirectFixedPath = true
	r.Run(":8181")
}

Expectations

$ curl 'localhost:8181/%E3%81%82' -L
{}
$ curl 'localhost:8181/%e3%81%82' -L
{}
$ curl 'localhost:8181/あ' -L
{}

Actual result

$ curl 'localhost:8181/%E3%81%82' -L
{}
$ curl 'localhost:8181/%e3%81%82' -L
curl: (47) Maximum (50) redirects followed
$ curl 'localhost:8181/あ' -L
curl: (47) Maximum (50) redirects followed

Environment

go version: 1.23.0
gin version (or commit ref): v1.10.0
operating system: macOS Sequoia

@JimChenWYU
Copy link

JimChenWYU commented Aug 20, 2024

image
image

Using /あ for comparison, but using /%e3%81%82 when redirecting, so it causes an infinite loop.


image

If using EscapedPath for comparison, responsing 404 not found


maybe we use req.URL.Path for redirecting, not useing req.URL.String().

@JimChenWYU
Copy link

image image

Using /あ for comparison, but using /%e3%81%82 when redirecting, so it causes an infinite loop.

image

If using EscapedPath for comparison, responsing 404 not found

maybe we use req.URL.Path for redirecting, not useing req.URL.String().

image

ohhh... when it set Location header, it will escape url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants