Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in wisely include only revisioned files #1060

Closed
giampaolo opened this issue May 10, 2017 · 2 comments
Closed

MANIFEST.in wisely include only revisioned files #1060

giampaolo opened this issue May 10, 2017 · 2 comments

Comments

@giampaolo
Copy link
Owner

giampaolo commented May 10, 2017

MANIFEST.in controls what files will end up in the source tar.gz distribution on python setup.py sdist. Right now MANIFEST.in is a static file edited manually which doesn't take into account about whether files are added, removed or moved via GIT. It also doesn't take into account files which may be in the working dir but are not under revision control. As such it'd be better to have a dynamic make generate-manifest command which uses git ls-files to get a list of all files under revision control and writes them in MANIFEST.in.
This way we'll be certain the tar.gz distribution has no extraneous or missing files.

@sethmlarson
Copy link

sethmlarson commented May 12, 2017

You could also check out this project which compares your MANIFEST.in against your VCS.

@giampaolo
Copy link
Owner Author

Yup, I already use it in psutil but thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants