Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): exportWithFormatter should work with undefined item prop #457

Merged
merged 1 commit into from
May 15, 2020

Conversation

ghiscoding-SE
Copy link
Collaborator

  • in some cases the user might have a formatter without any value or a "field" that is not in the dataContext, this however shouldn't block the use of exportWithFormatter

- in some cases the user might have a formatter without any value or a "field" that is not in the dataContext, this however shouldn't block the use of exportWithFormatter
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #457 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          147       147           
  Lines         9203      9204    +1     
  Branches      3058      3059    +1     
=========================================
+ Hits          9203      9204    +1     
Impacted Files Coverage Δ
...les/angular-slickgrid/services/export-utilities.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c91f35...38eea57. Read the comment docs.

@ghiscoding ghiscoding merged commit 3cfcab1 into master May 15, 2020
@ghiscoding ghiscoding deleted the bugfix/export-with-formatter-empty-value branch May 15, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants