Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Pagination Size is not working as expected #456

Closed
ghiscoding opened this issue May 14, 2020 · 1 comment · Fixed by #459
Closed

Custom Pagination Size is not working as expected #456

ghiscoding opened this issue May 14, 2020 · 1 comment · Fixed by #459
Labels
bug

Comments

@ghiscoding
Copy link
Owner

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular all
Angular-Slickgrid all
TypeScript all

Describe the Bug

Custom Pagination is not working as expected, this bug was asked on this Stack Overflow Question

Steps to Reproduce

See the Stack Overflow Question

In the config I have given the page sizes as [5, 10, 15, 20, 25, 50, 75] but in the UI it is coming as [5, 10, 15, 20, 25, 50, 75, 75, 100]

Expected Behavior

Providing Custom Pagination array should work

Current Behavior

There are duplicates and extras in the Pagination Size dropdown

Possible Solution

Code Sample
@ghiscoding ghiscoding added the bug label May 14, 2020
@ghiscoding ghiscoding changed the title (bug) Custom Pagination Size is not working as expected Custom Pagination Size is not working as expected May 14, 2020
ghiscoding-SE added a commit that referenced this issue May 14, 2020
@ghiscoding-SE
fix(pagination): passing custom pagination sizes should work, fixes #456
92bbe53
@ghiscoding-SE ghiscoding-SE mentioned this issue May 15, 2020
Merged
ghiscoding pushed a commit that referenced this issue May 15, 2020
@ghiscoding-SE
fix(pagination): passing custom pagination sizes should work, fixes #456
0367625 
 (#459)

* fix(pagination): passing custom pagination sizes should work, fixes #456
@ghiscoding
Copy link
Owner Author

This is now available in latest version 2.18.x.

Please upvote ⭐ if you haven't already.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@ghiscoding