Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): add queryFieldNameGetterFn callback know which field to use #434

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

ghiscoding-SE
Copy link
Collaborator

@ghiscoding-SE ghiscoding-SE commented Apr 24, 2020

in certain occasion we don't know at hand which field name to use, we might just know depending on certain logic (e.g. if item dataContext has a product type "I" then use field "catalogNumber" but if it's type "P" use field "productCategoryNumber", ...)

in certain occasion we don't have know at hand which field name to use, we might just know depending on certain logic (e.g. if item dataContext has a product type "I" then use field "catalogNumber" but if it's type "P" use field "productCategoryNumber", ...)
@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #434    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          141       141            
  Lines         8891      8899     +8     
  Branches      2945      3076   +131     
==========================================
+ Hits          8891      8899     +8     
Impacted Files Coverage Δ
...dules/angular-slickgrid/services/filter.service.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/services/sort.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7a65a...77b336c. Read the comment docs.

@ghiscoding ghiscoding merged commit 0d5a150 into master Apr 24, 2020
@ghiscoding ghiscoding deleted the feat/query-field-name-getter branch April 24, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants