Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resizer): remove scrollbar measure compensate patch #424

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

ghiscoding
Copy link
Owner

  • that was a temporary patch that was put in place to compensate for incorrect scrollbar measure happening in some browser like Chrome. This patch is no longer necessary since the bug was fixed in SlickGrid (core)

- that was a temporary patch that was put in place to compensate for incorrect scrollbar measure happening in some browser like Chrome. This patch is no longer necessary since the bug was fixed in SlickGrid (core)
@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #424 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #424   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         141    141           
  Lines        8870   8855   -15     
  Branches     3063   3059    -4     
=====================================
- Hits         8870   8855   -15
Impacted Files Coverage Δ
...pp/modules/angular-slickgrid/services/utilities.ts 100% <ø> (ø) ⬆️
...lickgrid/components/angular-slickgrid.component.ts 100% <ø> (ø) ⬆️
...ules/angular-slickgrid/services/resizer.service.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bdcd1...362d484. Read the comment docs.

@ghiscoding ghiscoding merged commit bca1f0b into master Mar 30, 2020
@ghiscoding ghiscoding deleted the bugfix/resizer-scrollbar-compensate branch March 30, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants