Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(selection): filter data should work with row selection, closes #295 #393

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

ghiscoding
Copy link
Owner

  • a new property "filteredDataContextIds" was added to handle possible filtered data with row selection

- a new property "filteredDataContextIds" was added to handle possible filtered data with row selection
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #393 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #393    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files         141    141            
  Lines        8832   8834     +2     
  Branches     2918   3045   +127     
======================================
+ Hits         8832   8834     +2
Impacted Files Coverage Δ
...s/angular-slickgrid/services/pagination.service.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08042eb...b322847. Read the comment docs.

@ghiscoding ghiscoding merged commit f36a4f7 into master Feb 5, 2020
@ghiscoding ghiscoding deleted the bugfix/row-selection-with-filter branch February 5, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants