Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function fit( ) not used #108

Closed
ctroupin opened this issue Oct 31, 2022 · 4 comments
Closed

Function fit( ) not used #108

ctroupin opened this issue Oct 31, 2022 · 4 comments

Comments

@ctroupin
Copy link
Member

Might be wrong but it seems the function fit() defined here:
https://github.com/gher-uliege/DIVAnd.jl/blob/master/src/fit.jl#L412
is not used in the code

@Alexander-Barth
Copy link
Member

Indeed, the function fit is not used because the functions fithorzlen and fitvertlen generally work better. So far, I did not removed this function because it might break other users code and maybe someday a way is found to improve them.

If this function fit cause confusion, maybe we should remove it as mentioned here:
https://gher-uliege.github.io/DIVAnd.jl/latest/#API-changes

@ctroupin
Copy link
Member Author

ctroupin commented Nov 2, 2022

Thanks Alex,
it probably makes sense to keep it then.
It caused me a bit (not a lot) of confusion while trying to reply to a user email about how the fit was working, but now it's clear!

@ctroupin ctroupin closed this as completed Nov 2, 2022
@Alexander-Barth
Copy link
Member

Would it help if we put them in a file called deprecated.jl ? (they would be still available but it would be clearer that they are not used)

@ctroupin
Copy link
Member Author

ctroupin commented Nov 2, 2022

Sure, that can be a clean way to do it. Or even if we write "deprecated" before the function definition in the source code can help when one has to dig into the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants