Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make llama.cpp depends on ggml #185

Open
zenixls2 opened this issue May 22, 2023 · 1 comment
Open

Make llama.cpp depends on ggml #185

zenixls2 opened this issue May 22, 2023 · 1 comment

Comments

@zenixls2
Copy link

zenixls2 commented May 22, 2023

  • cmake:
    ExternalProject

  • Makefile
    git clone

  • changes required in ggml:

    • move examples/common* out to include/ggml/
    • move some frequently used functions in llama.cpp to include/ggml/llm and src/
  • changes required in llama.cpp:

    • simplify llama.cpp by including/extending ggml/include/ggml/llm/
    • CMakeFile to re-export flags from ggml

Don't want to depend on conan since it adds more dependencies.
And I think it's time to make decisions... as the project's getting more and more complex.

@marella
Copy link
Contributor

marella commented May 23, 2023

I was also thinking of suggesting something similar. For example, llama_sample_* functions can be reused by other models.

Author might already have similar plans #145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants