Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgsl-in] Introduce an enum for wgsl attributes and use that for exhaustive tests #4567

Open
fornwall opened this issue Aug 13, 2023 · 1 comment
Open

[wgsl-in] Introduce an enum for wgsl attributes and use that for exhaustive tests #4567

fornwall opened this issue Aug 13, 2023 · 1 comment
Labels
area: naga front-end area: tests Improvements or issues with our test suite kind: refactor Making existing function faster or nicer lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request

Comments

@fornwall
Copy link
Contributor

Follow up work on gfx-rs/naga#2428:

Introduce an enum for supported wgsl attributes and use that to guarantee exhaustive test coverage for these attributes.
@fornwall
Copy link
Contributor Author

I plan to do this as soon as gfx-rs/naga#2428 has landed.

@fornwall fornwall mentioned this issue Aug 13, 2023
Merged
@teoxoy teoxoy added kind: refactor Making existing function faster or nicer lang: WGSL WebGPU Shading Language area: naga front-end type: enhancement New feature or request labels Aug 17, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@teoxoy teoxoy added the area: tests Improvements or issues with our test suite label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: naga front-end area: tests Improvements or issues with our test suite kind: refactor Making existing function faster or nicer lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fornwall @cwfitzgerald @teoxoy