-
Notifications
You must be signed in to change notification settings - Fork 211
/
span_processor_test.go
403 lines (355 loc) · 13.3 KB
/
span_processor_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
//go:build go1.18
package sentryotel
import (
"context"
"log"
"testing"
"github.com/getsentry/sentry-go"
"github.com/getsentry/sentry-go/internal/testutils"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/sdk/resource"
otelSdkTrace "go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.12.0"
"go.opentelemetry.io/otel/trace"
)
func setupSpanProcessorTest() (otelSdkTrace.SpanProcessor, *otelSdkTrace.TracerProvider, trace.Tracer) {
// Make sure that the global span map is empty
sentrySpanMap.Clear()
spanProcessor := NewSentrySpanProcessor()
tp := otelSdkTrace.NewTracerProvider(
otelSdkTrace.WithSampler(otelSdkTrace.AlwaysSample()),
otelSdkTrace.WithResource(
resource.NewWithAttributes(
"",
semconv.ServiceNameKey.String("test-otel"),
),
),
)
tp.RegisterSpanProcessor(spanProcessor)
tracer := tp.Tracer("test-tracer")
return spanProcessor, tp, tracer
}
func emptyContextWithSentry() context.Context {
client, _ := sentry.NewClient(sentry.ClientOptions{
Dsn: "https://abc@example.com/123",
Environment: "testing",
Release: "1.2.3",
EnableTracing: true,
TracesSampleRate: 1.0,
Transport: &TransportMock{},
})
hub := sentry.NewHub(client, sentry.NewScope())
return sentry.SetHubOnContext(context.Background(), hub)
}
func getSentryTransportFromContext(ctx context.Context) *TransportMock {
hub := sentry.GetHubFromContext(ctx)
transport, ok := hub.Client().Transport.(*TransportMock)
if !ok {
log.Fatal(
"Cannot get mock transport from context",
)
}
return transport
}
func TestNewSentrySpanProcessor(t *testing.T) {
spanProcessor := NewSentrySpanProcessor()
if _, valid := spanProcessor.(*sentrySpanProcessor); !valid {
t.Errorf(
"Invalid type returned by the span processor constructor: %#v\n",
spanProcessor,
)
}
}
func TestSpanProcessorShutdown(t *testing.T) {
spanProcessor, _, tracer := setupSpanProcessorTest()
ctx := context.Background()
tracer.Start(emptyContextWithSentry(), "spanName")
assertEqual(t, sentrySpanMap.Len(), 1)
spanProcessor.Shutdown(ctx)
// The span map should be empty
assertEqual(t, sentrySpanMap.Len(), 0)
}
func TestSpanProcessorForceFlush(t *testing.T) {
// This test is pretty naive at the moment and just checks that
// ForceFlush() doesn't crash or return an error. Ideally we test it
// with a Sentry transport that can be checked to see if events were
// actually flushed.
spanProcessor, _, tracer := setupSpanProcessorTest()
ctx, span := tracer.Start(emptyContextWithSentry(), "spanName")
span.End()
err := spanProcessor.ForceFlush(ctx)
if err != nil {
t.Errorf("Error from ForceFlush(): %v", err)
}
}
func TestOnStartRootSpan(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
_, otelSpan := tracer.Start(emptyContextWithSentry(), "spanName")
if sentrySpanMap.Len() != 1 {
t.Errorf("Span map size is %d, expected: 1", sentrySpanMap.Len())
}
sentrySpan, ok := sentrySpanMap.Get(otelSpan.SpanContext().SpanID())
if !ok {
t.Errorf("Sentry span not found in the map")
}
otelTraceId := otelSpan.SpanContext().TraceID()
otelSpanId := otelSpan.SpanContext().SpanID()
// TODO(anton): use a simple "assert", not "assertEqual"
assertTrue(t, otelSpan.SpanContext().IsValid())
assertEqual(t, sentrySpan.SpanID.String(), otelSpanId.String())
assertEqual(t, sentrySpan.TraceID.String(), otelTraceId.String())
assertEqual(t, sentrySpan.ParentSpanID, sentry.SpanID{})
assertTrue(t, sentrySpan.IsTransaction())
assertEqual(t, sentrySpan.Sampled, sentry.SampledTrue)
assertEqual(t, sentrySpan.Name, "spanName")
testutils.AssertBaggageStringsEqual(
t,
sentrySpan.ToBaggage(),
"sentry-transaction=spanName,sentry-environment=testing,sentry-public_key=abc,sentry-release=1.2.3,sentry-sample_rate=1,sentry-sampled=true,sentry-trace_id="+otelTraceId.String(),
)
}
func TestOnStartWithTraceParentContext(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
// Sentry context
ctx := context.WithValue(
emptyContextWithSentry(),
sentryTraceParentContextKey{},
sentry.TraceParentContext{
TraceID: TraceIDFromHex("d4cda95b652f4a1592b449d5929fda1b"),
ParentSpanID: SpanIDFromHex("6e0c63257de34c92"),
Sampled: sentry.SampledFalse,
},
)
dsc := sentry.DynamicSamplingContext{
Frozen: true,
Entries: map[string]string{"environment": "dev"},
}
ctx = context.WithValue(ctx, dynamicSamplingContextKey{}, dsc)
// Otel span context
ctx = trace.ContextWithSpanContext(
ctx,
trace.NewSpanContext(trace.SpanContextConfig{
TraceID: otelTraceIDFromHex("bc6d53f15eb88f4320054569b8c553d4"),
SpanID: otelSpanIDFromHex("b72fa28504b07285"),
TraceFlags: trace.FlagsSampled,
}),
)
_, otelSpan := tracer.Start(ctx, "spanName")
if sentrySpanMap.Len() != 1 {
t.Errorf("Span map size is %d, expected: 1", sentrySpanMap.Len())
}
sentrySpan, ok := sentrySpanMap.Get(otelSpan.SpanContext().SpanID())
if !ok {
t.Errorf("Sentry span not found in the map")
}
assertTrue(t, otelSpan.SpanContext().IsValid())
assertEqual(t, sentrySpan.SpanID.String(), otelSpan.SpanContext().SpanID().String())
// We're currently taking trace id and parent span id from the otel span context,
// (not sentry-trace header), mostly to be aligned with other SDKs.
assertEqual(t, sentrySpan.TraceID.String(), "bc6d53f15eb88f4320054569b8c553d4")
assertEqual(t, sentrySpan.ParentSpanID, SpanIDFromHex("b72fa28504b07285"))
assertTrue(t, sentrySpan.IsTransaction())
assertEqual(t, sentrySpan.Sampled, sentry.SampledFalse)
assertEqual(t, sentrySpan.Name, "spanName")
assertEqual(t, sentrySpan.Status, sentry.SpanStatusUndefined)
assertEqual(t, sentrySpan.Source, sentry.SourceCustom)
testutils.AssertBaggageStringsEqual(
t,
sentrySpan.ToBaggage(),
"sentry-environment=dev",
)
}
func TestOnStartWithExistingParentSpan(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
// Otel span context
ctx := trace.ContextWithSpanContext(
emptyContextWithSentry(),
trace.NewSpanContext(trace.SpanContextConfig{
TraceID: otelTraceIDFromHex("bc6d53f15eb88f4320054569b8c553d4"),
SpanID: otelSpanIDFromHex("b72fa28504b07285"),
TraceFlags: trace.FlagsSampled,
}),
)
ctx, otelRootSpan := tracer.Start(ctx, "rootSpan")
_, otelChildSpan := tracer.Start(ctx, "childSpan")
if sentrySpanMap.Len() != 2 {
t.Errorf("Span map size is %d, expected: 2", sentrySpanMap.Len())
}
sentryTransaction, ok1 := sentrySpanMap.Get(otelRootSpan.SpanContext().SpanID())
if !ok1 {
t.Errorf("Sentry span not found in the map")
}
sentryChildSpan, ok2 := sentrySpanMap.Get(otelChildSpan.SpanContext().SpanID())
if !ok2 {
t.Errorf("Sentry span not found in the map")
}
assertTrue(t, otelChildSpan.SpanContext().IsValid())
assertTrue(t, otelRootSpan.SpanContext().IsValid())
assertEqual(t, sentryChildSpan.ParentSpanID, sentryTransaction.SpanID)
assertEqual(t, sentryChildSpan.SpanID.String(), otelChildSpan.SpanContext().SpanID().String())
assertEqual(t, sentryChildSpan.TraceID.String(), "bc6d53f15eb88f4320054569b8c553d4")
assertFalse(t, sentryChildSpan.IsTransaction())
assertEqual(t, sentryChildSpan.GetTransaction().Name, "rootSpan")
assertEqual(t, sentryChildSpan.Op, "childSpan")
}
func TestOnEndWithTransaction(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
ctx, otelSpan := tracer.Start(
emptyContextWithSentry(),
"transactionName",
trace.WithAttributes(
attribute.String("key1", "value1"),
),
)
sentryTransaction, _ := sentrySpanMap.Get(otelSpan.SpanContext().SpanID())
assertTrue(t, sentryTransaction.EndTime.IsZero())
otelSpan.End()
// The span map should be empty
assertEqual(t, sentrySpanMap.Len(), 0)
// EndTime should be populated
assertFalse(t, sentryTransaction.EndTime.IsZero())
assertEqual(t, sentryTransaction.Status, sentry.SpanStatusOK)
assertEqual(t, sentryTransaction.Source, sentry.TransactionSource("custom"))
assertEqual(t, sentryTransaction.Op, "")
assertEqual(t, sentryTransaction.Description, "")
// One events should be captured by transport
sentryTransport := getSentryTransportFromContext(ctx)
events := sentryTransport.Events()
assertEqual(t, len(events), 1)
event := events[0]
assertEqual(t, event.StartTime, sentryTransaction.StartTime)
otelContextGot := event.Contexts["otel"]
assertEqual(
t,
otelContextGot,
map[string]interface{}{
"attributes": map[attribute.Key]string{
"key1": "value1",
},
"resource": map[attribute.Key]string{
"service.name": "test-otel",
},
},
)
}
func TestOnEndWithChildSpan(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
ctx, otelRootSpan := tracer.Start(emptyContextWithSentry(), "rootSpan")
_, otelChildSpan := tracer.Start(
ctx,
"childSpan",
trace.WithAttributes(
attribute.String("childKey1", "value1"),
),
)
sentryTransaction, _ := sentrySpanMap.Get(otelRootSpan.SpanContext().SpanID())
sentryChildSpan, _ := sentrySpanMap.Get(otelChildSpan.SpanContext().SpanID())
otelChildSpan.End()
otelRootSpan.End()
// The span map should be empty
assertEqual(t, sentrySpanMap.Len(), 0)
// EndTime should be populated
assertFalse(t, sentryTransaction.EndTime.IsZero())
assertFalse(t, sentryChildSpan.EndTime.IsZero())
assertEqual(t, sentryChildSpan.Status, sentry.SpanStatusOK)
assertEqual(t, sentryChildSpan.Source, sentry.TransactionSource(""))
assertEqual(t, sentryChildSpan.Op, "")
assertEqual(t, sentryChildSpan.Description, "childSpan")
assertEqual(
t,
sentryChildSpan.Data,
map[string]interface{}{
"childKey1": "value1",
"otel.kind": "internal",
},
)
// One events should be captured by transport
sentryTransport := getSentryTransportFromContext(ctx)
events := sentryTransport.Events()
assertEqual(t, len(events), 1)
assertEqual(t, events[0].StartTime, sentryTransaction.StartTime)
}
func TestOnEndDoesNotFinishSentryRequests(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
ctx, otelSpan := tracer.Start(
emptyContextWithSentry(),
"POST to Sentry",
// Hostname is same as in Sentry DSN
trace.WithAttributes(attribute.String("http.url", "https://example.com/api/123/envelope/")),
)
sentrySpan, _ := sentrySpanMap.Get(otelSpan.SpanContext().SpanID())
otelSpan.End()
// The span map should be empty
assertEqual(t, sentrySpanMap.Len(), 0)
// EndTime should NOT be populated
assertTrue(t, sentrySpan.EndTime.IsZero())
// No events should be captured by transport
sentryTransport := getSentryTransportFromContext(ctx)
events := sentryTransport.Events()
assertEqual(t, len(events), 0)
}
func TestParseSpanAttributesHttpClient(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
ctx, otelRootSpan := tracer.Start(
emptyContextWithSentry(),
"rootSpan",
trace.WithSpanKind(trace.SpanKindClient),
trace.WithAttributes(attribute.String("http.method", "GET")),
trace.WithAttributes(attribute.String("http.url", "http://localhost:1234/api/checkout1?q1=q2#fragment")),
)
_, otelChildSpan := tracer.Start(ctx,
"childSpan",
trace.WithSpanKind(trace.SpanKindClient),
trace.WithAttributes(attribute.String("http.method", "POST")),
trace.WithAttributes(attribute.String("http.url", "http://localhost:2345/api/checkout2?q1=q2#fragment")),
)
sentryTransaction, _ := sentrySpanMap.Get(otelRootSpan.SpanContext().SpanID())
sentrySpan, _ := sentrySpanMap.Get(otelChildSpan.SpanContext().SpanID())
otelChildSpan.End()
otelRootSpan.End()
// Transaction
assertEqual(t, sentryTransaction.Name, "GET http://localhost:1234/api/checkout1")
assertEqual(t, sentryTransaction.Description, "")
assertEqual(t, sentryTransaction.Op, "http.client")
assertEqual(t, sentryTransaction.Source, sentry.TransactionSource("url"))
// Span
assertEqual(t, sentrySpan.Name, "")
assertEqual(t, sentrySpan.Description, "POST http://localhost:2345/api/checkout2")
assertEqual(t, sentrySpan.Op, "http.client")
assertEqual(t, sentrySpan.Source, sentry.TransactionSource(""))
}
func TestParseSpanAttributesHttpServer(t *testing.T) {
_, _, tracer := setupSpanProcessorTest()
ctx, otelRootSpan := tracer.Start(
emptyContextWithSentry(),
"rootSpan",
trace.WithSpanKind(trace.SpanKindServer),
trace.WithAttributes(attribute.String("http.method", "GET")),
trace.WithAttributes(attribute.String("http.target", "/api/checkout1?k=v")),
// We ignore "http.url" if "http.target" is present
trace.WithAttributes(attribute.String("http.url", "http://localhost:1234/api/checkout?q1=q2#fragment")),
)
_, otelChildSpan := tracer.Start(
ctx,
"span name",
trace.WithSpanKind(trace.SpanKindServer),
trace.WithAttributes(attribute.String("http.method", "POST")),
trace.WithAttributes(attribute.String("http.target", "/api/checkout2?k=v")),
// We ignore "http.url" if "http.target" is present
trace.WithAttributes(attribute.String("http.url", "http://localhost:2345/api/checkout?q1=q2#fragment")),
)
sentryTransaction, _ := sentrySpanMap.Get(otelRootSpan.SpanContext().SpanID())
sentrySpan, _ := sentrySpanMap.Get(otelChildSpan.SpanContext().SpanID())
otelChildSpan.End()
otelRootSpan.End()
// Transaction
assertEqual(t, sentryTransaction.Name, "GET /api/checkout1")
assertEqual(t, sentryTransaction.Description, "")
assertEqual(t, sentryTransaction.Op, "http.server")
assertEqual(t, sentryTransaction.Source, sentry.TransactionSource("url"))
// Span
assertEqual(t, sentrySpan.Name, "")
assertEqual(t, sentrySpan.Description, "POST /api/checkout2")
assertEqual(t, sentrySpan.Op, "http.server")
assertEqual(t, sentrySpan.Source, sentry.TransactionSource(""))
}