Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Refactor #197

Open
3 tasks
sadiqkhoja opened this issue Aug 22, 2024 · 0 comments
Open
3 tasks

CSS Refactor #197

sadiqkhoja opened this issue Aug 22, 2024 · 0 comments
Labels

Comments

@sadiqkhoja
Copy link
Contributor

From #164 (comment)

  • Naming things: maybe this will be better addressed with PrimeVue 4, but it would be nice if we had fewer magic values and more use of system of CSS variables or other named values. Will hopefully make it easier to understand why something changes, e.g. font-weight 400 to 500 (or vice versa), font-size changes, accommodations for spacing moving up or down component/DOM hierarchy
  • Various use of negative margins is concerning. Especially where it seems to be counteracting spacing controlled by the same general thing (FormPanel). Would generally like to do a focused overhaul on how layout/spacing/alignment/etc are handled.
    • In such focused overhaul, also want to be mindful of RTL where we have styles producing asymmetric horizontal spacing/alignment
  • In general, worth thinking about:
    • System for naming and categorical structuring of components
    • How that can/will align with designs in Figma, tokens in PrimeVue, our own token system
@sadiqkhoja sadiqkhoja added the UI label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

1 participant