XForm with reserved entity property name can be uploaded in new version

[matthew-white]

When you upload an XLSForm that would create entities, pyxform will check that a reserved name is not used for an entity property (i.e., name or label). pyxform returns an error message like this:

The XLSForm could not be converted: [row : 2] Invalid save_to name: the entity property name 'name' is reserved.

If you upload an XForm instead of an XLSForm, then Backend will complete the check. If you try to create a new form using such an XForm, Backend will return an error message like this:

The entity definition within the form is invalid. Invalid Dataset property.

However, it looks like Backend only checks this when a new form is created, not when a new version is created for an existing form. I was able to upload an XForm with the entity property names name and label here: https://test.getodk.cloud/#/projects/444. I think we should complete this check whenever an XForm is uploaded, not just when a new form is created.

[matthew-white]

@ktuite, am I right in thinking that this was addressed in #810?

[ktuite]

Yes, this was addressed in #810. (Just looked and confirmed.)

I also just added a test for this case in #845 when I went back and did more validation of entity/dataset property names.

[dbemke]

Tested With Success!

[srujner]

Tested With Success!