Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolving refs is not cached #334

Closed
bojanz opened this issue Apr 6, 2021 · 1 comment · Fixed by #469
Closed

Resolving refs is not cached #334

bojanz opened this issue Apr 6, 2021 · 1 comment · Fixed by #469

Comments

@bojanz
Copy link

bojanz commented Apr 6, 2021

From what I can see in swagger_loader.go, if a document has 10 references to the same document, the document will be fetched and parsed 10 times. If we were to cache by URL, we could significantly speed up document loading.
@bojanz bojanz mentioned this issue Apr 7, 2021
Open
@fenollp
Copy link
Collaborator

fenollp commented Apr 7, 2021

Thanks for reporting.
Maybe you'd like to take on #117 ?

@cmars cmars mentioned this issue Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: cache resolved refs, improve URI reader extensibility cmars/kin-openapi
2 participants
@fenollp @bojanz