Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move AdvectionField out of Simulator #5887

Open
tjhei opened this issue Jun 12, 2024 · 0 comments
Open

move AdvectionField out of Simulator #5887

tjhei opened this issue Jun 12, 2024 · 0 comments

Comments

@tjhei
Copy link
Member

tjhei commented Jun 12, 2024

  • including simulator.h just for that is wasteful
  • it is currently a member of Simulator, so the qualified name is typename Simulator<dim>::AdvectionField which is annoying and verbose.

see #5802 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant