Move report types to lib #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maps and sets are used to enfore unicity of package IDs and paths. - Serialization is made deterministic by ordering sequences. This allows diff'ing outputs. - Test full and quick reports with existing crate data set. - Copy test data to allow tests to run concurrently (otherwise there would be IO errors, e.g. about file deletion).
So that they can be compared to the actual reports.
As per the `cargo` docs, they are respectively a local filesystem-based registry and a directory-based registry.
`cargo` fails to use an overriding path dependency when the manifest path given to `cargo build` is a UNC path (starting with `\\?\`). This was causing test7 test cases to fail.
|
Hey, sorry for taking so long to respond, have been exceptionally busy lately. I have briefly looked through the code and it looks good to me, let's get this merged and fix potential mistakes later. |
|
Don't be sorry. I think you respond pretty fast, especially for a project you're probably working on on your free time. Thank you for the merge and please let me know if there are areas you'd like me to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serializable types were moved to their own lib crate so that they can be deserialized in tests and other crates. The json output was made deterministic. Tests validate json reports for the exisiting crate data set.
For #117
Thank you and sorry for the long PR.