Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: test_redis.py #718

Merged
merged 1 commit into from
Jan 9, 2024
Merged

refactor: test_redis.py #718

merged 1 commit into from
Jan 9, 2024

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Jan 8, 2024

Features

  • refactor unit test code

geekan
geekan approved these changes Jan 8, 2024
View reviewed changes
Copy link
Owner

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that unittest.mock is used here, is it optimal?

@geekan geekan merged commit 2522857 into geekan:main Jan 9, 2024
1 of 2 checks passed
@iorisa iorisa deleted the refactor/unittest branch January 19, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekan geekan geekan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iorisa @geekan