Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path-length extraction of bbox-like polygons #478

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

nikosavola
Copy link
Member

@nikosavola nikosavola commented Aug 26, 2024

@mdecea

  • Use gdsfactory logger instead of prints in path_length_analysis_from_gds
  • No under-sampling on bbox polys in path_length_analysis_from_gds

Copy link
Contributor

sourcery-ai bot commented Aug 26, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@nikosavola nikosavola self-assigned this Aug 26, 2024
@github-actions github-actions bot added the bug Something isn't working label Aug 26, 2024
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab self-requested a review August 26, 2024 14:15
@nikosavola nikosavola merged commit adcfd5d into main Aug 26, 2024
5 of 17 checks passed
@nikosavola nikosavola deleted the bbox-poly-extract-path-fix branch August 26, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants