-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix netlist extraction issue #458
Conversation
Having only a str doesn't allow us ot use aliases
The reversed layer map stores PDK layers. Not KLayout interla layer indices.
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! thank you Niko!
This should fix #457
I had to essentialy revert parts of ea58fbd, b560343 and c2e607e. I guess conversion to gdsfactory8 in those broke some of the logic, for example not loading the correct default tech file and not supporting aliases in the layer map.