Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdsfactory850 #435

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update gdsfactory850 #435

merged 3 commits into from
Jul 10, 2024

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jul 9, 2024

more gdsfactory7 to gdsfactory8 conversions

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 9, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab added the bug Something isn't working label Jul 10, 2024
@joamatab joamatab merged commit 39411cb into main Jul 10, 2024
9 of 17 checks passed
@joamatab joamatab deleted the update_gdsfactory850 branch July 10, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai Sourcery AI Sourcery AI left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joamatab